Hi Peter, Am Freitag, den 12.12.2014, 15:09 +0800 schrieb Peter Chen: > All imx usb controller's non core registers uses the same clock gate with > core registers, the usbmisc_imx is the library for imx glue driver, the > glue keeps clock on when it calls usbmisc_imx API to change non-core register. Is this true for all i.MX variants down to i.MX25? > Besides, we will support runtime pm in the future, it also needs to > close this clock when the usb is not in use. I would have expected the clk_prepare_enable / disable_unprepare to move from probe / remove into the init / post callbacks instead. regards Philipp > Philipp Zabel also verifies it at imx6q platform, see > http://www.spinics.net/lists/linux-usb/msg118491.html > > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> > --- > drivers/usb/chipidea/usbmisc_imx.c | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c > index 58591e9..e988e36 100644 > --- a/drivers/usb/chipidea/usbmisc_imx.c > +++ b/drivers/usb/chipidea/usbmisc_imx.c > @@ -11,7 +11,6 @@ > > #include <linux/module.h> > #include <linux/of_platform.h> > -#include <linux/clk.h> > #include <linux/err.h> > #include <linux/io.h> > #include <linux/delay.h> > @@ -69,7 +68,6 @@ struct usbmisc_ops { > struct imx_usbmisc { > void __iomem *base; > spinlock_t lock; > - struct clk *clk; > const struct usbmisc_ops *ops; > }; > > @@ -322,7 +320,6 @@ static int usbmisc_imx_probe(struct platform_device *pdev) > { > struct resource *res; > struct imx_usbmisc *data; > - int ret; > struct of_device_id *tmp_dev; > > data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); > @@ -336,20 +333,6 @@ static int usbmisc_imx_probe(struct platform_device *pdev) > if (IS_ERR(data->base)) > return PTR_ERR(data->base); > > - data->clk = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(data->clk)) { > - dev_err(&pdev->dev, > - "failed to get clock, err=%ld\n", PTR_ERR(data->clk)); > - return PTR_ERR(data->clk); > - } > - > - ret = clk_prepare_enable(data->clk); > - if (ret) { > - dev_err(&pdev->dev, > - "clk_prepare_enable failed, err=%d\n", ret); > - return ret; > - } > - > tmp_dev = (struct of_device_id *) > of_match_device(usbmisc_imx_dt_ids, &pdev->dev); > data->ops = (const struct usbmisc_ops *)tmp_dev->data; > @@ -360,8 +343,6 @@ static int usbmisc_imx_probe(struct platform_device *pdev) > > static int usbmisc_imx_remove(struct platform_device *pdev) > { > - struct imx_usbmisc *usbmisc = dev_get_drvdata(&pdev->dev); > - clk_disable_unprepare(usbmisc->clk); > return 0; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
