Re: [PATCH v2] usb: core: buffer: smallest buffer should start at ARCH_DMA_MINALIGN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/27/2014 04:50 AM, Greg Kroah-Hartman wrote:
>> @@ -171,8 +172,11 @@ struct usb_hcd {
>>  	struct usb_hcd		*shared_hcd;
>>  	struct usb_hcd		*primary_hcd;
>>  
>> -
>> -#define HCD_BUFFER_POOLS	4
>> +#if ARCH_KMALLOC_MINALIGN <= 64
>> +	#define HCD_BUFFER_POOLS	4
>> +#else
>> +	#define HCD_BUFFER_POOLS	3
>> +#endif
>>  	struct dma_pool		*pool[HCD_BUFFER_POOLS];
>>  
>>  	int			state;
> 
> This breaks the build so badly, it's obvious you never tested it out.

I'm deeply sorry for this. It compiles fine on ARM for instance. But on
x86 it uses "__alignof__(unsigned long long)" and gcc's preprocessor
can't handle this.

> never do that again.
> 
> greg k-h
> 

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux