Peter, On Mon, Oct 20, 2014 at 11:10 PM, Peter Chen <Peter.Chen@xxxxxxxxxxxxx> wrote: > >> >> If 'evdo' property is not defined, then reading the >> MX25_USB_PHY_CTRL_OFFSET register is an unneeded operation. >> >> Move the reading of MX25_USB_PHY_CTRL_OFFSET inside the 'evdo' if block >> code, where it is actually used. >> >> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> >> --- >> drivers/usb/chipidea/usbmisc_imx.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/usb/chipidea/usbmisc_imx.c >> b/drivers/usb/chipidea/usbmisc_imx.c >> index 926c997..29200eb 100644 >> --- a/drivers/usb/chipidea/usbmisc_imx.c >> +++ b/drivers/usb/chipidea/usbmisc_imx.c >> @@ -117,10 +117,9 @@ static int usbmisc_imx25_post(struct >> imx_usbmisc_data *data) >> if (data->index > 2) >> return -EINVAL; >> >> - reg = usbmisc->base + MX25_USB_PHY_CTRL_OFFSET; >> - >> if (data->evdo) { >> spin_lock_irqsave(&usbmisc->lock, flags); >> + reg = usbmisc->base + MX25_USB_PHY_CTRL_OFFSET; >> val = readl(reg); >> writel(val | MX25_BM_EXTERNAL_VBUS_DIVIDER, reg); >> spin_unlock_irqrestore(&usbmisc->lock, flags); >> -- >> 1.9.1 > > Applied, Thanks. Where has this been applied? I still don't see it in linux-next. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html