Re: [PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe Balbi <balbi@xxxxxx> writes:

> On Mon, Nov 24, 2014 at 10:45:03PM +0100, Robert Jarzmik wrote:
>> Felipe Balbi <balbi@xxxxxx> writes:
>> 
>> > @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = {
>> >  	} while (0)
>> >  #define remove_debug_files(dev) \
>> >  	do { \
>> > -		if (dev->debugfs_udc) \
>> > -			debugfs_remove(dev->debugfs_udc); \
>> > +		debugfs_remove(dev->debugfs_udc); \
>> >  	} while (0)
>> 
>> Why this simpler form ?
>> #define remove_debug_files(dev) debugfs_remove(dev->debugfs_udc)
>
> sure, I'll do that. Do I get a Review-by ?
Of course.

Reviewed-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux