Re: net2280: is use_dma_chaining obsolete?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Felipe


>
> might be better if you can fix the code, instead. We have a "better"
> scatter-gather support in the framework itself.

As I understand it, the code was designed to reduce the number of irqs
when you expect to send X consecutive packages. In that scenario you
only want an irq at the end. ie, u_ether supports it. It was not
designed for sg.

The problem is that the driver only allocates one sg descriptor per
endpoint, without the possibility of chaining the request I dont see
how can this can work. And it does not work on my hw.

If you could confirm what I am saying about the dma_chaining by
testing it on net2280 then I think we should remote the module
parameter, because it will only confuse the user and also ofuscates a
lot the code.

>
> UDC needs to set gadget->sg_supported and a pointer to the sg should be
> passed in by the gadget driver through usb_request->sg.

I could try to implement "pure" sg on net2282.c , but I will only be
able to test it on usb338x hardware. If you could test it later I can
give it a try.

Regards!

-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux