On 11/21/2014 04:44 PM, Alan Stern wrote: > Commit ac61d1955934 (scsi: set correct completion code in > scsi_send_eh_cmnd()) introduced a bug. It changed the stored return > value from a queuecommand call, but it didn't take into account that > the return value was used again later on. This patch fixes the bug by > changing the later usage. > > There is a big comment in the middle of scsi_send_eh_cmnd() which > does a good job of explaining how the routine works. But it mentions > a "rtn = FAILURE" value that doesn't exist in the code. This patch > adjusts the code to match the comment (I assume the comment is right > and the code is wrong). > > This fixes Bugzilla #88341. > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Reported-by: Андрей Аладьев <aladjev.andrew@xxxxxxxxx> > Tested-by: Андрей Аладьев <aladjev.andrew@xxxxxxxxx> > Fixes: ac61d19559349e205dad7b5122b281419aa74a82 > CC: Hannes Reinecke <hare@xxxxxxx> > CC: <stable@xxxxxxxxxxxxxxx> > That is correct. Acked-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
