On Wed, 19 Nov 2014, Thomas Petazzoni wrote:
> Dear Marcin Wojtas,
>
> On Thu, 13 Nov 2014 00:49:50 +0100, Marcin Wojtas wrote:
> > This commit fixes ehci-orion operation in big-endian mode by enabling byteswap
> > when accessing registers using 'rdl' and 'wrl' macros.
> >
> > Signed-off-by: Grzegorz Jaszczyk <jaz@xxxxxxxxxxxx>
> > Signed-off-by: Marcin Wojtas <mw@xxxxxxxxxxxx>
> > Reviewed-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
>
> Tested-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
>
> Indeed, on Armada XP GP, without this patch, no USB devices are
> detected when the kernel runs in big endian mode. With this patch
> applied, a USB key is properly detected and I can mount/access it.
>
> Moreover, using {readl,writel}_relaxed() is safe here: even though
> those I/O accessors are not yet available on all architectures, the
> ehci-orion driver has a "depends on PLAT_ORION", so it can only be
> enabled on ARM, which has those accessors available.
>
> Greg, Alan, could you apply Marcin's patch?
Greg, since this changes only the platform code and none of the core
EHCI code, it's okay with me.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
