Re: Possible memory leak in acm_probe not freeing (acm->country_codes) on error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver Neukum <oneukum@xxxxxxx> writes:
> On Thu, 2014-11-20 at 14:27 +0100, Johan Hovold wrote:
>
>> It looks like it's never freed in the alloc_fail8 error path of probe,
>> though.
>
> Indeed. A case of the coder being blind to his own code.
> Patch is forthcoming.

Why does the driver have to allocate anything at all for this purpose?
Couldn't it just save a pointer to the country functional descriptor,
and let the "show" functions decode that when necessary?


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux