On Wed, 19 Nov 2014, Alan Stern wrote:
> On Wed, 19 Nov 2014, Андрей Аладьев wrote:
>
> > I've tested with 3.18-rc5. It looks the same.
>
> I was able to duplicate the problem in 3.18-rc5. Give me some time to
> investigate it, and I'll get back to you.
The patch below fixed the problem on my machine. Does it prevent all
those errors on your system? It corrects a bug that was introduced by
commit ac61d1955934.
Alan Stern
Index: 3.18-rc5/drivers/scsi/scsi_error.c
===================================================================
--- 3.18-rc5.orig/drivers/scsi/scsi_error.c
+++ 3.18-rc5/drivers/scsi/scsi_error.c
@@ -1027,7 +1027,7 @@ retry:
}
/* signal not to enter either branch of the if () below */
timeleft = 0;
- rtn = NEEDS_RETRY;
+ rtn = FAILED;
} else {
timeleft = wait_for_completion_timeout(&done, timeout);
rtn = SUCCESS;
@@ -1067,7 +1067,7 @@ retry:
rtn = FAILED;
break;
}
- } else if (!rtn) {
+ } else if (rtn != FAILED) {
scsi_abort_eh_cmnd(scmd);
rtn = FAILED;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
