On 11/17/2014 07:54 PM, Greg KH wrote: > On Mon, Nov 17, 2014 at 06:30:28PM -0600, Felipe Balbi wrote: >> Hi, >> >> On Mon, Nov 17, 2014 at 06:19:54PM -0500, Jorge Ramirez-Ortiz wrote: >>> Hi, >>> >>> This patch adds USB3 support to the legacy gadget printer driver. >>> Applies cleanly on fc14f9c Linux 3.18-rc5. >>> >>> Please could it be considered for inclusion? >> sure, if you send it properly (see Documentation/SubmittingPatches), >> provide logs of your tests with a recent kernel (v3.18-rc5 would be just >> awesome) and Cc myself on your resubmission. >> >>> diff --git a/drivers/usb/gadget/legacy/printer.c b/drivers/usb/gadget/legacy/printer.c >>> index 6474081..625d905 100644 >>> --- a/drivers/usb/gadget/legacy/printer.c >>> +++ b/drivers/usb/gadget/legacy/printer.c >>> @@ -3,6 +3,7 @@ >>> * >>> * Copyright (C) 2003-2005 David Brownell >>> * Copyright (C) 2006 Craig W. Nadler >>> + * Copyright (C) 2014 Linaro.org >> I don't think the minimal change below constitutes enough to merit the >> copyright. If your lawyers tell you otherwise, let me know. >> >> Greg, what's Linux Foundation's lawyers take on this ? > I'm not going to speak for the Linux Foundation here (we have no > in-house lawyers), but I have been advised that you need to modify/add > at least 1/3 of the file before you can add your copyright notice to a > file. That's the rule I go by, and numerous lawyers I have asked about > this say it is a safe rule to follow. > > Linaro should also be following those rules, last I checked with them, > so Jorge, you should go back and ask for clarification. Yes, let's drop the copyright - my fault. > > But then there's the issue that copyright notices in files really don't > mean anything, but I'm not going to get into that discussion right now :) > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
