On Thu, 13 Nov 2014, Benson Leung wrote: > On Thu, Nov 13, 2014 at 12:41 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > > usbhid_stop probably doesn't need it. And it should be possible to fix > > usbhid_close more easily just by interchanging the two lines: > > > > - usb_kill_urb(usbhid->urbin); > > usbhid->intf->needs_remote_wakeup = 0; > > + usb_kill_urb(usbhid->urbin); > > > > Have you tried this? > > Yes, I tried that as well, and that does work. > > I used the get/put because that's the way it was done in other > drivers, for example in synusb_close() in > drivers/input/mouse/synaptics_usb.c In the patch description, you wrote: > When a usbhid device that does not support remote wake > ( i.e. !device_can_wakeup() ) is closed, we fail out of > autosuspend_check() because the autosuspend check is called > before the flag is cleared as a result of usb_kill_urb(usbhid->urbin); If you interchange the two lines then the flag _will_ be cleared before usb_kill_urb() and autosuspend_check() can run. This means your patch description is bogus. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
