From: Hayes Wang <hayeswang@xxxxxxxxxxx> Date: Mon, 10 Nov 2014 03:29:27 +0000 > The behavior is different for PCI(e) and USB ethernet device. > The PCI nic could know the ring buffer by certain way, so > the device could fill the data into the buffer one by one > automatically. However, for usb nic, the driver has to > indicate (i.e. submit) each buffer for each data. The device > doesn't know what is the next buffer by itself. That is, > the driver determines the order by which the data would be > filled. > > Therefore, when I try to submit 10 rx buffers and some of > them fail, I could get the data depending on the order of > the successful ones. Besides, the driver has to submit the > buffer for next data continually, so the previous unsuccessful > ones could be tried again for the same time. Ok, but if we are looping here in rtl_start_rx() and r8152_submit_rx() fails due to a memory allocation failure, there is nothing which is going to make such a memory allocation succeed in the next iteration of the loop. Unless you can prove that often it can succeed after an initial failure, this is just wasted work and in fact making it take longer for the system to reclaim memory when under pressure because these extra iterations are completely wasted cpu work. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
