Hi Felipe, On Monday 10 November 2014 08:56 PM, Felipe Balbi wrote: > Hi, > > On Tue, Nov 04, 2014 at 03:30:54PM +0530, Kiran Kumar Raparthy wrote: >> @@ -1469,6 +1484,7 @@ static int ab8500_usb_probe(struct platform_device *pdev) >> >> abx500_usb_link_status_update(ab); >> >> + usb_phy_wsource_init(&ab->phy); > > instead of adding this to all drivers, you can just it to > usb_add_phy_dev() and conversely, to usb_remove_phy(). 'usb_phy_wsource_init' seems specific to usb and when these drivers are adapted to the generic PHY framework we can't add it to phy_create. Should it be added in extcon instead? Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html