Re: [PATCH v2] storage: Fix bus scan and multi-LUN support for SCM eUSCSI devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 8 Nov 2014 16:27:54 -0500 (EST)
Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:

> On Sat, 8 Nov 2014, Mark Knibbs wrote:
> 
> > It seems I didn't take into account the recent patch
> > "SCSI: Don't store LUN bits in CDB[1] for USB mass-storage devices"[1],
> > which causes my patch to not work properly. I should have actually tested it
> > before posting. Sigh.
> > 
> > [1] https://www.mail-archive.com/linux-usb@xxxxxxxxxxxxxxx/msg47868.html
> > 
> > Patch [1] added this code to usb_stor_probe2():
> >         /*
> >          * Like Windows, we won't store the LUN bits in CDB[1] for SCSI-2
> >          * devices using the Bulk-Only transport (even though this violates
> >          * the SCSI spec).
> >          */
> >         if (us->transport == usb_stor_Bulk_transport)
> >                 us_to_host(us)->no_scsi2_lun_in_cdb = 1;
> > 
> > That breaks multi-LUN support for an Entrega USB-SCSI converter with an MPL
> > MCDISK dual-slot PCMCIA drive. Probably all SCM-based converters would be
> > affected similarly. Whichever LUN is specified, LUN 0 is always accessed.
> 
> Have you tested these devices with a host running Windows?

I tested in a Windows VM which had the SCM driver installed. There the LUN
bits in CDB[1] were not always zero, and I could access both slots of the
MCDISK device. I plan to test in a Windows VM with no SCM driver installed
tomorrow.


Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux