Re: your mail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/07/2014 06:58 PM, Felipe Balbi wrote:
>> If I put pm_runtime_get_sync() + put in musb_resume() then the problem
> 
> shouldn't you have:
> 
> 	pm_runtime_disable(dev);
> 	pm_runtime_set_active(dev);
> 	pm_runtime_enable(dev);
> 
> in musb_resume() ?

that might be correct, I am asking for the right thing to do :)
But I also question the purpose of this pm_runtime_.* in musb. It is
done only in probe. So if the device hits idle, we won't restore regs
in ISR, correct? Okay, we may not have an irq because the device is off
(fair point). But what about enqueue + dequeue? I couldn't find out why
we have it except that it got here via omap2430 and then core has been
"balanced out" in case the platform is not using pm_runtime at all.

Sebastian


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux