On Wed, 2014-11-05 at 11:30 -0800, Christoph Hellwig wrote: > On Wed, Nov 05, 2014 at 11:34:11AM -0500, Alan Stern wrote: > > > Sorry, meant to. In principle I'm OK with this as the lever for the > > > hack (largely because it means we don't need to do anything) but will > > > the distributions support it? > > > > While I can't speak for the distributions, it's reasonable to assume > > that if something becomes part of the upstream kernel then they will > > include it. > > Btw, we do have precedence for looking at partition tables from SCSI > code with scsi_partsize(), so the layering violation of looking at > EFI labels for disks sizes wouldn't be something entirely new even > if we did it in kernel space. We really don't want to make the decision within the kernel of whether we believe the partition size or the disk capacity. For these disk problems we need it to be the former, but if we choose that always, we'll get weird results on mispartitioned devices. The usual rule is no policy in the kernel and which to choose is policy, so just export the knob (as Alan's patch does) and then let userspace decide. James -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
