Hi Varka,
On 31/10/2014 02:14, Varka Bhadram wrote:
> From: Varka Bhadram <varkabhadram@xxxxxxxxx>
>
> Sanity check on resource happening with devm_ioremap_resource().
Reviewed-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
Thanks,
Gregory
>
> Signed-off-by: Varka Bhadram <varkab@xxxxxxx>
> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/host/xhci-plat.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 3d78b0c..e68b4ec 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -83,9 +83,6 @@ static int xhci_plat_probe(struct platform_device *pdev)
> if (irq < 0)
> return -ENODEV;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return -ENODEV;
>
> if (of_device_is_compatible(pdev->dev.of_node,
> "marvell,armada-375-xhci") ||
> @@ -109,15 +106,16 @@ static int xhci_plat_probe(struct platform_device *pdev)
> if (!hcd)
> return -ENOMEM;
>
> - hcd->rsrc_start = res->start;
> - hcd->rsrc_len = resource_size(res);
> -
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> hcd->regs = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(hcd->regs)) {
> ret = PTR_ERR(hcd->regs);
> goto put_hcd;
> }
>
> + hcd->rsrc_start = res->start;
> + hcd->rsrc_len = resource_size(res);
> +
> /*
> * Not all platforms have a clk so it is not an error if the
> * clock does not exists.
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
