Re: [PATCH v2] usb: gadget: Add UDC driver for Broadcom USB3.0 device controller IP BDC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 31, 2014 at 10:44 AM, Felipe Balbi <balbi@xxxxxx> wrote:
> On Fri, Oct 31, 2014 at 09:51:03AM -0700, Ashwini Pahuja wrote:
>>     - The v2 version includes all the feedback provided by Felipe on the v1 and also
>>               -- Removed unnecessary out of memory messages.
>>               -- Added usb_gadget_giveback_request
>>               -- udc_stop: removed unnecessary driver argument.
>>               -- Removed unused defines
>>               -- Renamed upsc to uspc
>>
>>     - I would consider adding tracepoint support in near future, but not immediately.
>>
>>     - This patch adds a UDC driver for Broadcom's USB3.0 device controller IP(BDC).
>>
>>     - The driver was written using the Felipe's USB testing/next branch as a baseline from:
>>             git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
>>
>>     - The driver is tested on FPGA-PCIe based platform using various gadget drivers such as zero, mass storage, ether(rndis), hid and also with tools such as USB3CV, USB2CV and Link layer compliance.
>
> you need to improve your commit log, There's way too much here which
> shouldn't go to git log. I won't review until this part is sorted out,
> sorry.
>
Re-sending the v2 again with improved commit log. Hope its OK now. thanks
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux