-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/30/2014 08:57 AM, Felipe Balbi wrote: > On Tue, Oct 28, 2014 at 06:25:43PM -0500, > dinguyen@xxxxxxxxxxxxxxxxxxxxx wrote: >> From: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx> >> >> This patch will aggregate the probing of gadget/hcd driver into >> platform.c. The gadget probe funtion is converted into >> gadget_init that is now only responsible for gadget only >> initialization. All the gadget resources is now > > s/resources is/resources are > >> handled by platform.c >> >> Since the host workqueue will not get initialized if the driver >> is configured for peripheral mode only. Thus we need to check for >> wq_otg before calling queue_work(). > > this period character in the middle of the sentence doesn't make > sense, perhaps a comma is what you want ? The sentence can be > improved too: > > "Since the host workqueue will not get initialized if the drier is > configured for peripheral mode only, we add a check for wq_otg > before calling queue_work()." > >> Also, we move spin_lock_init to common location for both host and >> gadget that is either in platform.c or pci.c. >> >> We also ove suspend/resume code to common platform code, and >> update it to use the new PM API (struct dev_pm_ops). > > updating to dev_pm_ops should really be a separate patch. > All fixed... Thanks, Dinh -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJUU6PAAAoJEBmUBAuBoyj0KJUP/RWpP9YkctpmZQgrb2xq0JaG eLCpOnKVYaTBCAhydJOKBBx0odYyxORlxTWbJCbZPvPhrZ7NDTINqEVWJOqYmtqe Xl8aEPYm+ckcfTliONK3yIP/MA49he/qbGOmqXFwFMbcAvKFN/kpq05cjzZ6T8bO hILDO2Yy2HVQHonq3uKppmTB9DSnCNfCR0Cuum2fpOzmVLY/X46EM5UD2e+XmVgo dsINAGe40FwFIoLZzAradn12MrmCjOM6MPpkkGZ3SMGjKXY7yQX38c9WbcCvsm6g y1/5fDqdRlsq+Weoo9N3H03LUX8MlGCpZ7dgLrABXMEjdySj3eVTj4bHgPxRjRY/ +SfI2YR8RyEcHj2UTqgMUp4JmRl2CNiB9fsvZHMQQm2MTeFkcUpZnSUXWHB9Vtwv s1I5nMOSoT2NDBg6QS9a1T1s1gdSywOnDBd+/SK7mf4QkQumvf2Nvu6avQB1Rxxm sqpGWztuhuycg332CXc9W0EBXcg5t8SRyk9SFgksH3MezS85gAQxZtXyv44NuCUM ciTru8tKh3ncszws2NmX9yyQgC4fM3kHDytOwDXFt23f3xHyjg+2m3O1TLErAwig yqj2MfYTfqfYVrs/hOvOpEbUgUSy5MQY/EOMIsI6aGfB2Nba72wrYQP79ugb84u9 Ftd1XH47lvXX/R8VOV2x =ZAkf -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
