Re: [PATCH usb v2 26/29] renesas_usbhs: common: remove duplicate check on resource

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/30/2014 10:46 PM, Sergei Shtylyov wrote:
On 10/30/2014 06:53 PM, varkabhadram@xxxxxxxxx wrote:

From: Varka Bhadram <varkabhadram@xxxxxxxxx>

Sanity check on resource happening with devm_ioremap_resource().

Signed-off-by: Varka Bhadram <varkab@xxxxxxx>
---
  drivers/usb/renesas_usbhs/common.c |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index b3b6813..3ffd552 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -497,8 +497,9 @@ static int usbhs_probe(struct platform_device *pdev)

      /* platform data */
      res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
      irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-    if (!res || !irq_res) {
+    if (!irq_res) {
dev_err(&pdev->dev, "Not enough Renesas USB platform resources.\n");
          return -ENODEV;
      }

   You promised to change this patch but haven't. Why?

WBR, Sergei

I addressed your comments in v3. Please review it.

--
Thanks and Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux