Hi shimoda-san > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > This patch fixes an issue that this driver always enable the D+ pullup > after it detected the VBUS connection even though this usb controller > can control the D+ pullup timing by software. So, this driver should > enable the D+ pullup after a gadget driver called usb_gadget_connect(). > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@xxxxxxxxxxx> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > --- (snip) > diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c > index 2d0903f..0d50be0 100644 > --- a/drivers/usb/renesas_usbhs/mod_gadget.c > +++ b/drivers/usb/renesas_usbhs/mod_gadget.c > @@ -56,6 +56,8 @@ struct usbhsg_gpriv { > #define USBHSG_STATUS_REGISTERD (1 << 1) > #define USBHSG_STATUS_WEDGE (1 << 2) > #define USBHSG_STATUS_SELF_POWERED (1 << 3) > + > + unsigned softconnect:1; > }; We can re-use USBHSG_STATUS_xxx instead of new variable ? renesas_usb driver has usbhsg_status_xxx() macro. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html