Re: xhci_hcd can't detect new devices after enabling runtime PM and disabling S3 wake (bug #85701)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 07, 2014 at 11:07:53AM -0400, Alan Stern wrote:
> 
> That's the difference.  It appears to be caused by a bug in xhci-hcd.
> Does the patch below fix the problem?
> 

Hi,

Your patch fixes it for me. So now USB port works well.

Thanks!

> 
> Index: usb-3.17/drivers/usb/host/xhci-hub.c
> ===================================================================
> --- usb-3.17.orig/drivers/usb/host/xhci-hub.c
> +++ usb-3.17/drivers/usb/host/xhci-hub.c
> @@ -1136,13 +1136,11 @@ int xhci_bus_suspend(struct usb_hcd *hcd
>  			t2 |= PORT_LINK_STROBE | XDEV_U3;
>  			set_bit(port_index, &bus_state->bus_suspended);
>  		}
> -		/* USB core sets remote wake mask for USB 3.0 hubs,
> -		 * including the USB 3.0 roothub, but only if CONFIG_PM_RUNTIME
> -		 * is enabled, so also enable remote wake here.
> +		/* USB core sets remote wake mask for USB 3.0 hubs but
> +		 * not for USB 2.0 hubs (and only if CONFIG_PM_RUNTIME
> +		 * is enabled), so enable remote wake here.
>  		 */
> -		if (hcd->self.root_hub->do_remote_wakeup
> -				&& device_may_wakeup(hcd->self.controller)) {
> -
> +		if (hcd->self.root_hub->do_remote_wakeup) {
>  			if (t1 & PORT_CONNECT) {
>  				t2 |= PORT_WKOC_E | PORT_WKDISC_E;
>  				t2 &= ~PORT_WKCONN_E;
> 
> 
> 

-- 
WBR, Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux