On Fri, 26 Sep 2014, Johan Hovold wrote: > Hot-pluggable multi-function devices should use PLATFORM_DEVID_AUTO to > avoid name collisions on the platform bus. > > This driver currently uses the USB-device address as an id. This makes > name collisions unlikely, but it could still happen if two devices are > connected to separate buses and gets assigned the same address. > > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx> > --- > drivers/mfd/rtsx_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch is superfluous. Just wait until the hotpluggable version is applied, then use it. > diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c > index 71f387ce8cbd..78073e4b87e4 100644 > --- a/drivers/mfd/rtsx_usb.c > +++ b/drivers/mfd/rtsx_usb.c > @@ -647,7 +647,7 @@ static int rtsx_usb_probe(struct usb_interface *intf, > /* initialize USB SG transfer timer */ > setup_timer(&ucr->sg_timer, rtsx_usb_sg_timed_out, (unsigned long) ucr); > > - ret = mfd_add_devices(&intf->dev, usb_dev->devnum, rtsx_usb_cells, > + ret = mfd_add_devices(&intf->dev, PLATFORM_DEVID_AUTO, rtsx_usb_cells, > ARRAY_SIZE(rtsx_usb_cells), NULL, 0, NULL); > if (ret) > goto out_init_fail; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
