Re: [PATCH 07/17] usb: isp1760: Remove busname argument to isp1760_register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 06, 2014 at 06:54:55PM +0300, Laurent Pinchart wrote:
> The argument is unused, remove it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Reviewed-by: Felipe Balbi <balbi@xxxxxx>

> ---
>  drivers/usb/host/isp1760-hcd.c |  2 +-
>  drivers/usb/host/isp1760-hcd.h |  2 +-
>  drivers/usb/host/isp1760-if.c  | 14 +++++---------
>  3 files changed, 7 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
> index c9b2bc2..1574bdd 100644
> --- a/drivers/usb/host/isp1760-hcd.c
> +++ b/drivers/usb/host/isp1760-hcd.c
> @@ -2218,7 +2218,7 @@ void isp1760_deinit_kmem_cache(void)
>  
>  int isp1760_register(phys_addr_t res_start, resource_size_t res_len, int irq,
>  		     unsigned long irqflags, int rst_gpio, struct device *dev,
> -		     const char *busname, unsigned int devflags)
> +		     unsigned int devflags)
>  {
>  	struct usb_hcd *hcd;
>  	struct isp1760_hcd *priv;
> diff --git a/drivers/usb/host/isp1760-hcd.h b/drivers/usb/host/isp1760-hcd.h
> index 6e4ccb4..4471dab 100644
> --- a/drivers/usb/host/isp1760-hcd.h
> +++ b/drivers/usb/host/isp1760-hcd.h
> @@ -4,7 +4,7 @@
>  /* exports for if */
>  int isp1760_register(phys_addr_t res_start, resource_size_t res_len, int irq,
>  		     unsigned long irqflags, int rst_gpio, struct device *dev,
> -		     const char *busname, unsigned int devflags);
> +		     unsigned int devflags);
>  void isp1760_unregister(struct device *dev);
>  
>  int isp1760_init_kmem_once(void);
> diff --git a/drivers/usb/host/isp1760-if.c b/drivers/usb/host/isp1760-if.c
> index 043ba03..16075fd 100644
> --- a/drivers/usb/host/isp1760-if.c
> +++ b/drivers/usb/host/isp1760-if.c
> @@ -96,10 +96,8 @@ static int of_isp1760_probe(struct platform_device *dev)
>  		}
>  	}
>  
> -	ret = isp1760_register(memory.start, res_len, virq,
> -					IRQF_SHARED, rst_gpio,
> -					&dev->dev, dev_name(&dev->dev),
> -					devflags);
> +	ret = isp1760_register(memory.start, res_len, virq, IRQF_SHARED,
> +			       rst_gpio, &dev->dev, devflags);
>  	if (ret < 0)
>  		goto free_gpio;
>  
> @@ -252,8 +250,8 @@ static int isp1761_pci_probe(struct pci_dev *dev,
>  
>  	dev->dev.dma_mask = NULL;
>  	ret_status = isp1760_register(pci_mem_phy0, memlength, dev->irq,
> -		IRQF_SHARED, -ENOENT, &dev->dev, dev_name(&dev->dev),
> -		devflags);
> +				      IRQF_SHARED, -ENOENT, &dev->dev,
> +				      devflags);
>  	if (ret_status < 0)
>  		goto cleanup3;
>  
> @@ -354,9 +352,7 @@ static int isp1760_plat_probe(struct platform_device *pdev)
>  	}
>  
>  	ret = isp1760_register(mem_res->start, mem_size, irq_res->start,
> -			       irqflags, -ENOENT,
> -			       &pdev->dev, dev_name(&pdev->dev), devflags);
> -
> +			       irqflags, -ENOENT, &pdev->dev, devflags);
>  	if (ret < 0) {
>  		pr_warning("isp1760: Failed to register the HCD device\n");
>  		goto cleanup;
> -- 
> 2.0.4
> 

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux