On Mon, Oct 06, 2014 at 06:54:49PM +0300, Laurent Pinchart wrote:
> The platform driver remove function needs to release the memory resource
> requested at probe time. Instead of retrieving the resource from the
> platform device, retrieve it from the usb_hcd. This mimics the behaviour
> of the PCI and OF glues, and will make it easier to share code between
> all three glue layers.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
looks good to me.
Reviewed-by: Felipe Balbi <balbi@xxxxxx>
> ---
> drivers/usb/host/isp1760-if.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/isp1760-if.c b/drivers/usb/host/isp1760-if.c
> index df931e9..4da0c49 100644
> --- a/drivers/usb/host/isp1760-if.c
> +++ b/drivers/usb/host/isp1760-if.c
> @@ -415,15 +415,11 @@ out:
>
> static int isp1760_plat_remove(struct platform_device *pdev)
> {
> - struct resource *mem_res;
> - resource_size_t mem_size;
> struct usb_hcd *hcd = platform_get_drvdata(pdev);
>
> usb_remove_hcd(hcd);
>
> - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mem_size = resource_size(mem_res);
> - release_mem_region(mem_res->start, mem_size);
> + release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
>
> usb_put_hcd(hcd);
>
> --
> 2.0.4
>
--
balbi
Attachment:
signature.asc
Description: Digital signature
