On Wed, Oct 01, 2014 at 09:15:23PM -0400, Don Zickus wrote:
> Recently our build environment changed and started turning some warnings into
> errors. One of the fallouts is this warning:
>
> CC [M] drivers/usb/misc/usb3503.o
> drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’:
> drivers/usb/misc/usb3503.c:195: warning: ‘err’ may be used uninitialized in this function
Doh. I rushed this and didn't realize this was already fixed in v3.17.
Sorry for the noise. My tree was only at v3.16. :-(
self-nak.
Cheers,
Don
>
> Fixed it by using the proper error. Compiled only as I don't have the hardware
> to test correctly.
>
> Signed-off-by: Don Zickus <dzickus@xxxxxxxxxx>
> ---
> drivers/usb/misc/usb3503.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
> index f43c619..773a3a6 100644
> --- a/drivers/usb/misc/usb3503.c
> +++ b/drivers/usb/misc/usb3503.c
> @@ -192,7 +192,7 @@ static int usb3503_probe(struct usb3503 *hub)
>
> clk = devm_clk_get(dev, "refclk");
> if (IS_ERR(clk) && PTR_ERR(clk) != -ENOENT) {
> - dev_err(dev, "unable to request refclk (%d)\n", err);
> + dev_err(dev, "unable to request refclk (%ld)\n", PTR_ERR(clk));
> return PTR_ERR(clk);
> }
>
> --
> 1.7.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
