> From: Charles Manning [mailto:cdhmanning@xxxxxxxxx] > Sent: Wednesday, October 01, 2014 7:36 PM > > The unioned u32 is used for clearing etc. Having the number of > bitfield bits add up to more than 32 is broken, even if benign. > > Signed-off-by: Charles Manning <cdhmanning@xxxxxxxxx> > --- > drivers/usb/dwc2/core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h > index 1efd10c..b778b5a 100644 > --- a/drivers/usb/dwc2/core.h > +++ b/drivers/usb/dwc2/core.h > @@ -611,7 +611,7 @@ struct dwc2_hsotg { > unsigned port_suspend_change:1; > unsigned port_over_current_change:1; > unsigned port_l1_change:1; > - unsigned reserved:26; > + unsigned reserved:25; > } b; > } flags; > Yep, nice catch. Acked-by: Paul Zimmerman <paulz@xxxxxxxxxxxx> BTW, please CC Felipe (balbi@xxxxxx) on all dwc2 patches from now on, they are going through his tree now instead of directly to Greg. I will resend this to Felipe after he reopens his tree, if he hasn't picked it up by then. Thanks. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
