Re: doubt in locking of queuecommand in storage driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-10-01 at 10:17 -0400, Alan Stern wrote:
> On Wed, 1 Oct 2014, Oliver Neukum wrote:
> 
> > Hi,
> > 
> > it seems to that there's a small window for the storage
> > driver to reject a command (and log an error) at the completion
> > of a command. Something like this patch should fix it.
> > What do you think?
> 
> There is no window.  Both queuecommand_lck and the relevant portion of
> usb_stor_control_thread (the part where us->srb->scsi_done gets called
> and us->srb is set to NULL) are protected by the host lock.

Oh, a macro. How subtle. Thanks.

	Sorry
		Oliver



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux