On Sat, 2014-09-27 at 15:01 +0200, Hans de Goede wrote:
[...]
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1146,10 +1146,12 @@ unsigned int xhci_last_valid_endpoint(u32 added_ctxs)
> * returns 0 this is a root hub; returns -EINVAL for NULL pointers.
> */
> static int xhci_check_args(struct usb_hcd *hcd, struct usb_device *udev,
> - struct usb_host_endpoint *ep, int check_ep, bool check_virt_dev,
> - const char *func) {
> + struct usb_host_endpoint *ep, bool check_ep,
> + bool check_ep_ring, bool check_virt_dev, const char *func)
[...]
Using three bool parameters is error-prone; please consider replacing
them with a flags parameter and named flags.
Ben.
--
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.
Attachment:
signature.asc
Description: This is a digitally signed message part
