[PATCH 00/12] libusbg: Fixes and small API improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Matt,

This series fixes a lot of bugs and makes API usage easier.

First two commits contains contains a difference between
libubsg/libusbg and kopasiak/libusbg repository.

List of fixed issues:
- doxygen typos
- Off-by-one error in usbg_get_function_type_str()
- remove unused variables
- Always append '\0' at the end of string

Also some small API changes has been done. Now user can choose
if he would like to get name as a constant string or copy the
name to his buffer. Of course name is valid only as long as 
related entity exist.

I have also added usbg_get/set_gadget_attr() to allow set
selected gadget attribute instead of using dedicated function
for each of them. It makes iteration over attributes much simpler.

I have created also a pull request:

https://github.com/libusbg/libusbg/pull/11

Moreover, I would like to suggest you to not use github merge
button. This button makes allways non-fast-forrward merge
so it generates always a merge commit. We have only 6 pull requests
merged till now and the history looks a litlle bit weird.
When we get more and more commist the history will get unnecessarily
complicated. In additions a lot of merge commits in upstream branch
causes some problems in gbs (used to build rpms in tizen).
Of course this is not a must but only a suggestion.

--
BR's
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics

Krzysztof Opasiak (11):
  libusbg: fix: reverse comparsion to fix error
  libusbg: doc: Fix typos in doxygen documentation
  libusbg: Fix off-by-one error.
  libusbg: fix: Remove unused variables
  libusbg: Always add '\0' at end of string
  libusbg: Simplify getting names form library structures
  libusbg: Allow to set all gadget attrs using one function.
  libusbg: Return suitable error codes instead of -1
  libusbg: Make usbg_lookup_function_type() publicly available
  libusbg: Add own name to AUTHORS file.
  libusbg: Don't print errno when it has not been directly set

Philippe De Swert (1):
  libusbg: Return USBG_ERROR_PATH_TOO_LONG error when it happens

 AUTHORS                 |    2 +
 examples/show-gadgets.c |   42 ++++++---
 include/usbg/usbg.h     |  164 +++++++++++++++++++++++++++++------
 src/usbg.c              |  218 +++++++++++++++++++++++++++++++++--------------
 4 files changed, 322 insertions(+), 104 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux