Re: [RFC PATCH 1/4] usb: dwc3: add AMD NL support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 26, 2014 at 12:26:05AM -0500, Felipe Balbi wrote:
> Hi,
> 
> On Fri, Sep 26, 2014 at 12:53:21PM +0800, Huang Rui wrote:
> > On Thu, Sep 25, 2014 at 09:53:55AM -0500, Felipe Balbi wrote:
> > > On Thu, Sep 25, 2014 at 03:21:44PM +0800, Huang Rui wrote:
> > > > Add PCI device ID of AMD NL.
> > > > 
> > > > Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
> > > > ---
> > > >  drivers/usb/dwc3/dwc3-pci.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> > > > index 436fb08..cebbd01 100644
> > > > --- a/drivers/usb/dwc3/dwc3-pci.c
> > > > +++ b/drivers/usb/dwc3/dwc3-pci.c
> > > > @@ -30,6 +30,7 @@
> > > >  #define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3	0xabcd
> > > >  #define PCI_DEVICE_ID_INTEL_BYT		0x0f37
> > > >  #define PCI_DEVICE_ID_INTEL_MRFLD	0x119e
> > > > +#define PCI_DEVICE_ID_AMD_NL		0x7912
> > > >  
> > > >  struct dwc3_pci {
> > > >  	struct device		*dev;
> > > > @@ -183,6 +184,7 @@ static const struct pci_device_id dwc3_pci_id_table[] = {
> > > >  	},
> > > >  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT), },
> > > >  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRFLD), },
> > > > +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_NL), },
> > > 
> > > this patch causes a build breakage.
> > > 
> > 
> > That's strange, I tested it once again in my side based on your "next"
> > branch and didn't find any build error. If I misunderstood your
> > meaning, please correct me. :)
> 
> no, I just misread your patch. I'm sorry. I thought the PCI Device ID
> was set to the quirk which was not defined here. I apologize, this patch
> is 100% correct.
> 

It doesn't matter, thanks a lot to your kindly support. :)

Thanks,
Rui
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux