Hi,
On Thu, Sep 25, 2014 at 03:44:34PM +0200, robert.jarzmik@xxxxxxx wrote:
> ----- Mail original -----
> De: "Linus Walleij" <linus.walleij@xxxxxxxxxx>
> À: "Robert Jarzmik" <robert.jarzmik@xxxxxxx>
> Cc: "Felipe Balbi" <balbi@xxxxxx>, linux-usb@xxxxxxxxxxxxxxx
> Envoyé: Jeudi 25 Septembre 2014 15:10:16
> Objet: Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support
>
> In that case, that whole clause is actually using the old API without
> explicit request, so you can just do this:
>
> if (mach) {
> /* This clause will go away when we have transitioned to
> just using descriptors */
> if (devm_gpio_request_one(&pdev->dev, mach->gpio_pullup,
> mach->gpio_pullup_inverted ?
> GPIOF_ACTIVE_LOW : 0,
> "my pin"))
> goto err;
> udc->gpiod = gpio_to_desc(mach->gpio_pullup);
> udc->mach = mach;
> } else {
> ...
> }
>
> Excellent, sold. I'll put that in partial v3 then.
hey, sounds good to me too :-)
> Could you also review patch 1/3 while at it ;) ?
>
> Felipe, I'll wait for a couple of days to release partial v3 to give
> you time to review the patches, let's say next wednesday ?
sure, but I'm liking where this is going. Looks like a nice transition
path.
--
balbi
Attachment:
signature.asc
Description: Digital signature
