Re: [PATCH v6 partial 0/2] pxa27x_udc port to device-tree and gpio_desc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 24, 2014 at 9:41 PM, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote:

> I have not found in the gpiolib anything for a driver to set that
> active_low value, only for machine code. The legacy behaviour was that
> that information was handed over to the driver.

That's correct, active low is a property of the electronics, and
not something the driver should mess with going forward.

Active low is now defined in either the descriptor table in the
machine, in the device tree or in ACPI nodes.

The old way was convoluted and something like:

board file defines custom platform data -> driver gets this
-> tells GPIOlib to use active low

Or in worst case the polarity is hard-coded in the driver (!)

That was not a clean separation, the driver should not need to
care about polarity, the core should handle this.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux