Felipe Balbi <balbi@xxxxxx> writes: > On Wed, Sep 24, 2014 at 09:41:12PM +0200, Robert Jarzmik wrote: >> For this preparation, a preliminary cleanup is done : >> - convert the probing of pxa27x_udc to gpio_desc. >> The conversion is partial because : >> - the platform data still provides a gpio number, not a gpio desc >> - the "invert" attribute is lost, hence a loss in the translation > > I asked for gpio to gpiod conversion to be a separate patch. It'll make > things a lot easier to review. What does patch 1/2 do then ? There are 2 lines for udc_command (1 in .h and 1.c), and all the remaining is the gpiod conversion. Is it difficult for you to review a "51 lines changed" patch you asked for ? Do you want me to ask other people to help you ? >> - convert the mach info, and store the udc_command in the pxa_udc >> control structure >> - loose the udc_is_connected() in mach info >> This was not really used, as mioa701 machine doesn't need it, >> balloon3 doesn't really use it, and most importantly the current >> driver never uses it. >> >> The drawback with the gpio_desc conversion is that the "inverted" gpio >> attribute is lost, as no gpiod_*() function exists to set the > > it's not lost, it's handled for you by the gpio library. Look at how > GPIO_ACTIVE_LOW is used. It is so, the above assertion "no gpiod_*() function exists" is false. Therefore, which is the right function in the gpio library accessible to a driver ? Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
