Re: [PATCH] Revert "usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 23, 2014 at 07:55:38AM -0700, Greg KH wrote:
> On Mon, Sep 22, 2014 at 09:28:26AM -0500, Felipe Balbi wrote:
> > Hi,
> > 
> > On Thu, Sep 18, 2014 at 09:31:32AM -0500, Felipe Balbi wrote:
> > > This reverts commit f2267089ea17fa97b796b1b4247e3f8957655df3.
> > > 
> > > That commit causes more problem than fixes. Firstly, kfree()
> > > should be called after usb_ep_dequeue() and secondly, the way
> > > things are, we will try to dequeue a request that has already
> > > completed much more frequently than one which is pending.
> > > 
> > > Cc: Li Jun <b47624@xxxxxxxxxxxxx>
> > > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > > ---
> > > 
> > > Greg, can you still apply this for v3.17 final ? Please take it as a patch
> > > directly so we avoid a pull request for a single patch. If you prefer a pull,
> > > let me know.
> > 
> > looks like -rc6 will be the last -rc for v3.17. If we can't get this on
> > v3.17-final, do you mind merging this on usb-next and add a Cc stable
> > #3.17 ?
> 
> Ick, sorry, missed this for an earlier release, will go do this now and
> queue it up that way.

Thanks

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux