Re: [PATCH v2 0/4] libusbg: Add support for functionfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 11, 2014 at 05:09:46PM +0200, Krzysztof Opasiak wrote:
> Dear Matt,
> 
> Configuration of function fs based functions using config fs has been
> merged to linux kernel quite long ago. To keep libusbg up to date I
> have prepared patches that add support for functionfs function type.
> 
> When working with ffs I noticed that it would be a good feature to
> provide device name directly to user and avoid him confusion that
> instance name has to be the same as device to mount ffs. That's why I
> have added structure for ffs attributes which has only one, pure
> virtual (not present in configfs and read-only) attribute dev_name.
> 
> Now user can create ffs function in a two ways:
> 
> 1) Pass instance name name and then get function attributes (device
> name)
> 
> 2) Pass NULL as instance name and pass function attributes with
> desired device name

This is great, I just made use of this in an application I'm working
on now and like it.

> First commit in this serie fix potential memory leak which could
> take place in usbg_init(). To avoid this usbg_init() has been
> refactored and now all memory should be free() properly.
> 
> I have created pull request on github with those patches [1].
> 
> Please also notice that there are still two pending patch series:
> 
> 1) Remove gadget functionality [2]
> This one has been changed according to your review but is still
> pending for over a month.
> 
> 2) Couple fixes from Philippe De Swert [3]
> That's a few commits which fix errors reported by coverity.
> I have reviewed this serie, build and run and it looks good
> to me. Please also run through this code and merge if you
> don't find anny issues.
> 

Applied to master, thanks!

-Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux