Re: [PATCH] storage: Don't scan target 7 for SCM USB-SCSI converters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 22 Sep 2014 10:17:02 -0400 (EDT)
Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, 22 Sep 2014, Mark wrote:
> 
> > When using an SCM-based USB-SCSI converter, access to target 7 is attempted
> > after scanning targets 0 to 6 during the bus scan. The SCSI ID of the
> > converter is hard-wired to 7 so there will never be a target there. I'm
> > proposing a small patch to usb_stor_probe2() so target 7 is not accessed;
> > see below.
> > ...
> > In usb_stor_probe2() there is:
> > 	if (!(us->fflags & US_FL_SCM_MULT_TARG))
> > 		us_to_host(us)->max_id = 1;
> > 
> > Change that to:
> > 	us_to_host(us)->max_id = (us->fflags & US_FL_SCM_MULT_TARG) ? 7 : 1;
> > 
> > Is that enough?
> 
> Try it and see.

I compiled a kernel with that change and it did solve the problem. Obviously it wasn't a very big problem, but the bus scan should be about 1/3 second faster now.


Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux