On Fri, Sep 19, 2014 at 01:23:03PM +0200, Andreas Bomholtz wrote:
> We have a USB dongle with the cp210x chip on.
> And we have put our own USB id into it.
>
> Signed-off-by: Andreas Bomholtz <andreas@xxxxxxxxxxx>
Thanks for the patch. There are just two minor issues. Your patch appear
to have been line wrapped by your mailer (check out git send-email), and
also you should use tabs for indentation.
> ---
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index e4bb622..abd7577 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -155,6 +155,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662
> Cable */
> { USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
> { USB_DEVICE(0x1BE3, 0x07A6) }, /* WAGO 750-923 USB Service
> Cable */
> + { USB_DEVICE(0x1D6F, 0x0010) }, /* Seluxit ApS RF Dongle */
> { USB_DEVICE(0x1E29, 0x0102) }, /* Festo CPX-USB */
> { USB_DEVICE(0x1E29, 0x0501) }, /* Festo CMSP */
> { USB_DEVICE(0x1FB9, 0x0100) }, /* Lake Shore Model 121 Current
> Source */
You can run your patch through scripts/checkpatch.pl before submitting
to catch some issues. Here it now says:
ERROR: patch seems to be corrupt (line wrapped?)
#18: FILE: drivers/usb/serial/cp210x.c:155:
*/
WARNING: please, no spaces at the start of a line
#21: FILE: drivers/usb/serial/cp210x.c:158:
+ { USB_DEVICE(0x1D6F, 0x0010) }, /* Seluxit ApS RF Dongle */$
total: 1 errors, 1 warnings, 8 lines checked
> ---
> git stable tag v3.9.9
Also try to base your patch on a more recent kernel (e.g. 3.16.3).
Care to fix this up and resubmit?
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
