On Wed, 17 Sep 2014, Petr Mladek wrote:
> The USB hub events are proceed by workqueue instead of kthread now.
> The result is that hub_event() function processes only one event.
> The block from the while cycle was not removed earlier to show the real
> changes when switching to the workqueue.
>
> When touching the code, it fixes also formatting of dev_err() and dev_dbg()
> calls to make checkpatch.pl happy :-)
More sylistic comments...
> + hub = container_of(work, struct usb_hub, events);
> + hdev = hub->hdev;
> + hub_dev = hub->intfdev;
> + intf = to_usb_interface(hub_dev);
> +
> + dev_dbg(hub_dev, "state %d ports %d chg %04x evt %04x\n",
> + hdev->state, hdev->maxchild,
> + /* NOTE: expects max 15 ports... */
> + (u16) hub->change_bits[0],
> + (u16) hub->event_bits[0]);
In this file, continuation lines are indented by 2 tab stops beyond the
starting line, not one.
> + if (test_bit(i, hub->event_bits)
> + || test_bit(i, hub->change_bits)
> + || test_bit(i, hub->wakeup_bits)) {
And not four spaces.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
