Hi, On Tue, Sep 16, 2014 at 08:40:14PM +0400, Matwey V. Kornilov wrote: > 2014-09-10 23:50 GMT+04:00 Felipe Balbi <balbi@xxxxxx>: > > hmmm, protocol error. > > Hi, > > I've found the root of the problem. CONFIG_USB_MUSB_TUSB6010=m affects > the code inside musb_hdrc inspite of tusb6010 not loaded at all. > When I disable CONFIG_USB_MUSB_TUSB6010 in my configuration, > everything works fine. hmm, true we still have some brain farts wrt tusb6010 support. > After the following modification, usb seems to be semi-working with > CONFIG_USB_MUSB_TUSB6010=m. > > diff --git a/drivers/usb/musb/musb_regs.h b/drivers/usb/musb/musb_regs.h > index 03f2655..a146b9a 100644 > --- a/drivers/usb/musb/musb_regs.h > +++ b/drivers/usb/musb/musb_regs.h > @@ -234,12 +234,7 @@ > #define MUSB_TESTMODE 0x0F /* 8 bit */ > > /* Get offset for a given FIFO from musb->mregs */ > -#if defined(CONFIG_USB_MUSB_TUSB6010) || \ > - defined(CONFIG_USB_MUSB_TUSB6010_MODULE) > -#define MUSB_FIFO_OFFSET(epnum) (0x200 + ((epnum) * 0x20)) > -#else > #define MUSB_FIFO_OFFSET(epnum) (0x20 + ((epnum) * 4)) > -#endif this can't be applied as it would break tusb6010. > I am still testing, and suspect that musb_readb/musb_writeb stuff in > musb_io.h is also the subject. > > The question is how to fix all this in correct way. the correct way would be very involved. Basically we need to strip musb core of tusb6010 specific code and move all that to the tusb6010 glue layer. -- balbi
Attachment:
signature.asc
Description: Digital signature
