> From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Paul Zimmerman > Sent: Thursday, September 11, 2014 1:10 PM > > > From: Paul Zimmerman > > Sent: Thursday, September 11, 2014 12:11 PM > > > > > From: Robert Baldyga [mailto:r.baldyga@xxxxxxxxxxx] > > > Sent: Thursday, September 11, 2014 5:53 AM > > > > > > These two patches breaks dwc2 driver. The first one causes build break, > > > the second breaks gadget at Samsung platforms. > > > > > > Best regards > > > Robert Baldyga > > > > > > Robert Baldyga (2): > > > Revert "usb: dwc2: Update Kconfig to support dual-role" > > > Revert "usb: dwc2: move "samsung,s3c6400-hsotg" into common platform" > > > > > > drivers/usb/dwc2/Kconfig | 63 +++++++++++++++++++-------------------------- > > > drivers/usb/dwc2/Makefile | 21 +++++++-------- > > > drivers/usb/dwc2/gadget.c | 1 + > > > drivers/usb/dwc2/platform.c | 1 - > > > 4 files changed, 38 insertions(+), 48 deletions(-) > > > > Yep, I can confirm the build breakage. Greg, we should revert these two > > before you send your update for the next -rc, if it's not too late. > > > > Dinh, before resending the series, please test that each individual > > patch does not break the build. > > FYI, I see the build breakage when using ARM multi_v7_defconfig, > with the mass-storage gadget enabled and dwc2 enabled for > peripheral-only mode: > > CC init/version.o > LD init/built-in.o > drivers/built-in.o: In function `dwc2_hc_set_even_odd_frame': > :(.text+0x21ca0c): undefined reference to `dwc2_hcd_get_frame_number' > drivers/built-in.o: In function `dwc2_handle_common_intr': > :(.text+0x21f5dc): undefined reference to `dwc2_hcd_start' > :(.text+0x21f660): undefined reference to `dwc2_hcd_start' > :(.text+0x21f7c4): undefined reference to `dwc2_hcd_start' > :(.text+0x21f974): undefined reference to `dwc2_hcd_disconnect' Hi Dinh, This change, after applying your first patch, fixes the build breakage for me: --- a/drivers/usb/dwc2/Makefile +++ b/drivers/usb/dwc2/Makefile @@ -2,9 +2,9 @@ ccflags-$(CONFIG_USB_DWC2_DEBUG) += -DDEBUG ccflags-$(CONFIG_USB_DWC2_VERBOSE) += -DVERBOSE_DEBUG obj-$(CONFIG_USB_DWC2) += dwc2.o -dwc2-y := core.o core_intr.o ifneq ($(filter y,$(CONFIG_USB_DWC2_HOST) $(CONFIG_USB_DWC2_DUAL_ROLE)),) + dwc2-y += core.o core_intr.o dwc2-y += hcd.o hcd_intr.o dwc2-y += hcd_queue.o hcd_ddma.o endif I didn't test whether the resulting drivers actually work, though. Maybe you could make that modification to your first patch, and then add back the move of core.o and core_intr.o to a later patch when the code is ready for it? -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
