Re: [PATCH 1/4] usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san,

(2014/09/11 8:56), Kuninori Morimoto wrote:
> 
> Hi Shimoda-san
> 
>> --- a/drivers/usb/renesas_usbhs/mod_gadget.c
>> +++ b/drivers/usb/renesas_usbhs/mod_gadget.c
>> @@ -602,6 +602,9 @@ static int usbhsg_ep_disable(struct usb_ep *ep)
>>  	struct usbhsg_uep *uep = usbhsg_ep_to_uep(ep);
>>  	struct usbhs_pipe *pipe = usbhsg_uep_to_pipe(uep);
>>
>> +	if (!uep || !uep->pipe)
>> +		return -EINVAL;
>> +
>>  	usbhsg_pipe_disable(uep);
>>  	usbhs_pipe_free(pipe);
> 
> If uep can be NULL,
> we need care about usbhsg_uep_to_pipe(uep) too.

Thank you for the point.
I will check the uep can be NULL or not.

> and, "uep->pipe" is same as "pipe" ?

Yes. I will use "pipe" instead of "uep->pipe".

Best regards,
Yoshihiro Shimoda

> Best regards
> ---
> Kuninori Morimoto
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux