On Wed, Sep 10, 2014 at 05:50:25PM +0200, Michal Nazarewicz wrote:
> Even though the BUG() in __ffs_event_add is a dead-code, it is still
> better to warn rather then crash the system if that code ever gets
> executed.
>
> Suggested-by: Felipe Balbi <balbi@xxxxxx>
> Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> ---
> This has been compile tested only.
>
> drivers/usb/gadget/function/f_fs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c
> index ec50e0d..74d48b3 100644
> --- a/drivers/usb/gadget/function/f_fs.c
> +++ b/drivers/usb/gadget/function/f_fs.c
> @@ -2321,7 +2321,9 @@ static void __ffs_event_add(struct ffs_data *ffs,
> break;
>
> default:
> - BUG();
> + pr_vdebug("%d: unknown event, this should not happen\n", type);
> + WARN_ON(1);
WARN(1, "unknown event type %d\n", type);
Then you can drop pr_vdebug();
--
balbi
Attachment:
signature.asc
Description: Digital signature
