On Mon, Sep 08, 2014 at 08:41:28AM -0500, Felipe Balbi wrote: > On Mon, Sep 08, 2014 at 11:45:27AM +0200, Robert Baldyga wrote: > > From: Kamil Debski <k.debski@xxxxxxxxxxx> > > > > When the driver is removed s3c_hsotg_phy_disable is called three times > > instead of once. This results in decreasing of the phy reference counter > > below zero and thus consecutive inserts of the module fails. > > > > This patch removes calls to s3c_hsotg_phy_disable from s3c_hsotg_remove > > and s3c_hsotg_udc_stop. > > > > s3c_hsotg_udc_stop is called from udc-core.c only after > > usb_gadget_disconnect, which in turn calls s3c_hsotg_pullup, which > > already calls s3c_hsotg_phy_disable. > > > > s3c_hsotg_remove must be called only after udc_stop, so there is no > > point in disabling phy once again there. > > > > Signed-off-by: Kamil Debski <k.debski@xxxxxxxxxxx> > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > > Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx> > > you should have received a note from Greg that this is not how you send > patches to be included in Stable, please read > Documentation/stable_kernel_rules.txt You beat me too it :) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
