Hi, On Mon, Sep 08, 2014 at 10:42:19AM +0200, Robert Baldyga wrote: > On 09/04/2014 09:49 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Sep 04, 2014 at 07:37:20PM +0000, Paul Zimmerman wrote: > >>> From: Felipe Balbi [mailto:balbi@xxxxxx] > >>> Sent: Thursday, September 04, 2014 12:18 PM > >>> > >>> On Thu, Sep 04, 2014 at 12:04:23PM -0700, Paul Zimmerman wrote: > >>>> From: Kamil Debski <k.debski@xxxxxxxxxxx> > >>>> > >>>> When the driver is removed s3c_hsotg_phy_disable is called three times > >>>> instead of once. This results in decreasing of the phy reference counter > >>>> below zero and thus consecutive inserts of the module fails. > >>>> > >>>> This patch removes calls to s3c_hsotg_phy_disable from s3c_hsotg_remove > >>>> and s3c_hsotg_udc_stop. > >>>> > >>>> s3c_hsotg_udc_stop is called from udc-core.c only after > >>>> usb_gadget_disconnect, which in turn calls s3c_hsotg_pullup, which > >>>> already calls s3c_hsotg_phy_disable. > >>>> > >>>> s3c_hsotg_remove must be called only after udc_stop, so there is no > >>>> point in disabling phy once again there. > >>>> > >>>> Signed-off-by: Kamil Debski <k.debski@xxxxxxxxxxx> > >>>> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > >>>> Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx> > >>>> Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx> > >>> > >>> looks like this one deserves a Cc: stable ? > >> > >> Good point. Robert, what do you think? Only problem is, this file > >> moved from drivers/usb/gadget/ to here in 3.16, so earlier stable > >> versions would require some additional backporting. > > > > Right, you'll receive a notification from Greg that the patch FAILED to > > apply and all you gotta do is provide a modified patch which, in this > > case, is just a path modification. > > I can rebase patchset at stable branch and send it separately. > > Felipe, should I rebase only patches you have pointed or rather entire > patchset? YBased on my latest comments, you need to figure out if some of these patches need to be sent for stable too, that would mean you need to add proper annotation to Cc: <stable@xxxxxxxxxxxxxxx> together with which is the earliest version that suffers from the problem and which commit introduced the bug. Then you need something like below in your commit log: Fixes: $abbreviated_commit (commit log summary) Cc: <stable@xxxxxxxxxxxxxxx> # v3.X+ Signed-off-by: Kamil Debski <k.debski@xxxxxxxxxxx> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx> Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx> Then, you need to resend your series so stable gets those patches. -- balbi
Attachment:
signature.asc
Description: Digital signature
