Re: [PATCH 0/1] for HID core dot c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

You're almost there. You may specifically want to read section 1.15.
Also have a look at how other people submit their patches. Using git
send-email[1] may also help.

It's also the custom to reply to all, instead of just to the mailing list.

Thanks,
Frans

[1] http://git-scm.com/docs/git-send-email

On Fri, Sep 5, 2014 at 4:30 PM, Hans Petter Selasky <hps@xxxxxxxxxxx> wrote:
> Hi,
>
> Looks like the first argument for MODULE_PARAM_DESC() is incorrect.
>
> --HPS
>
> commit 862e8673263b82652b5738ccda4f8367959fa234
> Author: Hans Petter Selasky <hps@xxxxxxxxxxx>
> Date:   Fri Sep 5 11:07:15 2014 +0200
>
>     Correct argument for Module parameter description.
>         Signed-off-by: Hans Petter Selasky <hps@xxxxxxxxxxx>
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 12b6e67..1956c72 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -52,7 +52,7 @@ EXPORT_SYMBOL_GPL(hid_debug);
>   static int hid_ignore_special_drivers = 0;
>  module_param_named(ignore_special_drivers, hid_ignore_special_drivers, int,
> 0600);
> -MODULE_PARM_DESC(debug, "Ignore any special drivers and handle all devices
> by generic driver");
> +MODULE_PARM_DESC(ignore_special_drivers, "Ignore any special drivers and
> handle all devices by generic driver");
>   /*
>   * Register a new report for a device.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux