On Wed, Aug 27, 2014 at 12:45 PM, Daniel Mack <daniel@xxxxxxxxxx> wrote: > On 08/27/2014 09:07 AM, Jassi Brar wrote: >> On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack <daniel@xxxxxxxxxx> wrote: > >>> Hmm? The first USB_XFERS packets will only contain zeros, and we're only >>> preparing those here. For every successive packet, the length is >>> recalculated and the audio material is copied in accordingly before the >>> requets is requeued. What buffers should overlap here? >>> >> For 44100/2/S16, req_len is 176 or 44 frames. But we need to send 45 >> frames in a packet occasionally. >> >> req[0]->buf = rbuf + 0 and req[1]->buf = rbuf + 176. > > No. req[0]->buf = rbuf + 0 and req[1]->buf = rbuf + max_psize. > You patch does - req->length = prm->max_psize; + req->length = req_len; Or did you send the wrong version of patch? where req_len is calculated as req_len = rate / uac2->p_interval; Clearly for 44.1/2/S16, req_len evaluates to 176. -jassi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html