From: Dan Williams > Sending as an RFC primarily to get feedback on the unit testing approach > while there's still time to yell at me in person at LinuxCon. Including > Rusty in pursuit of comments on how to do mocked interfaces for testing > purposes in-tree. > > === > > This series updates the xhci driver to honor all the rules specified in > section 4.11.7.1 of the xhci specification (v1.1). See the changelog > for patch 19 for more background. > > Patches 1-18 are cleanups, fixes, and smaller ring geometry changes to > support patches 19 and 20. If you only review one of these patches > please review patch 20 ("xhci: unit test ring enqueue/dequeue routines") > to see the current passing test cases and please do propose additional > ones. As it stands Sarah would like, and I agree, that we need a > cancellation unit test before proposing this for inclusion. Have you looked at the patches I sent a while back? They included a whole set of tidyups to make the code easier to read. Unfortunately I rather overloaded Sarah at the time. Another change I didn't get as far as coding was to cache the doorbell address and value within the ring (I think they can't change), making 'ringing the bell' much faster. David ��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥