On Fri, Aug 22, 2014 at 12:33:10PM -0300, Rodrigo Severo wrote:
> Renesas uPD720202 USB 3.0 chip needs XHCI_TRUST_TX_LENGTH quirk workaround as per below logs
> produced when using a Diammond video capture dongle:
>
> Aug 21 18:07:33 [kernel] handle_tx_event: 67 callbacks suppressed
> Aug 21 18:07:33 [kernel] xhci_hcd 0000:01:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?
> - Last output repeated 9 times -
>
> While at it I took the opportunity to define Renesas uPD720202 device ID.
>
> Signed-off-by: Rodrigo Severo <rodrigo@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/host/xhci-pci.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 47390e3..52df456 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -38,6 +38,8 @@
> #define PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI 0x8c31
> #define PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_XHCI 0x9c31
>
> +#define PCI_DEVICE_ID_RENESAS_UPD720202 0x0015
Minor nit, can you use a tab to line up the value properly?
Also, please use scripts/get_maintainer.pl to send the patch to the
proper person, I don't know if the xhci maintainer saw this patch :(
> +
> static const char hcd_name[] = "xhci_hcd";
>
> /* called after powerup, by probe or system-pm "wakeup" */
> @@ -143,10 +145,12 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> xhci->quirks |= XHCI_TRUST_TX_LENGTH;
> }
> if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
> - pdev->device == 0x0015 &&
> - pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG &&
> - pdev->subsystem_device == 0xc0cd)
> - xhci->quirks |= XHCI_RESET_ON_RESUME;
> + pdev->device == PCI_DEVICE_ID_RENESAS_UPD720202) {
> + xhci->quirks |= XHCI_TRUST_TX_LENGTH;
You just added this quirk to devices that previously didn't seem to need
it, why?
> + if (pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG &&
> + pdev->subsystem_device == 0xc0cd)
> + xhci->quirks |= XHCI_RESET_ON_RESUME;
Can't we just get a table of quirks instead of logic functions to make
this easier to add new ones?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
