On Fri, Aug 22, 2014 at 2:42 PM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Aug 22, 2014 at 10:39:03AM -0700, Bryan Wu wrote: >> On Fri, Aug 22, 2014 at 4:53 AM, Michal Sojka <sojka@xxxxxxxxx> wrote: >> > With this patch, USB gadget activity can be signaled by blinking a LED. >> > >> > Since there is no generic code where to put the trigger for all USB >> > controllers, each USB controller needs to call the trigger individually. >> > This patch adds the call only for the musb controller where I can test >> > it. >> > >> >> Generally I think one led trigger for both USB host and USB gadget >> activity is good enough. We don't need 2 same led trigger here. > > What about systems that have both running at the same time? Don't you > want individual control? > Actually I wanted to say we don't need 2 same driver for USB host and USB gadget but one driver which has 2 led triggers like usb_host_ledtrig and usb_gadget_ledtrig. I think drivers/net/can/led.c is a good example to start. >> And probably you can just put this code in drivers/usb subsystem, >> since this driver is quite simple to add to USB subsystem. > > I have no objection to that, if the LED people don't mind it. > Because logically it's only used by USB subsystem and it can be a core component of USB, also drivers/net/can/led.c is a good example. Thanks, -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
